Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade testing dependencies #668

Merged
merged 3 commits into from Oct 11, 2017
Merged

Upgrade testing dependencies #668

merged 3 commits into from Oct 11, 2017

Conversation

tech4him1
Copy link
Contributor

- Summary
Upgrade Jest and Enzyme testing dependencies.

- Test plan
Ran yarn test and yarn test -u. No changes were needed and all tests passed.

- Description for the changelog
Upgrade testing dependencies.

- A picture of a cute animal (not mandatory but encouraged)

Versions for React were also updated to comply with Enzyme peer-deps
(the actual `yarn.lock` version didn't change).
@tech4him1 tech4him1 changed the title Upgrade testing dependencies WIP: Upgrade testing dependencies Oct 10, 2017
@tech4him1 tech4him1 changed the title WIP: Upgrade testing dependencies Upgrade testing dependencies Oct 10, 2017
Copy link
Contributor

@Benaiah Benaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I'd already reviewed this; sorry. LGTM.

@Benaiah Benaiah merged commit 8bf21ca into master Oct 11, 2017
@tech4him1 tech4him1 deleted the upgrade-testers branch October 11, 2017 23:56
@tech4him1
Copy link
Contributor Author

tech4him1 commented Oct 13, 2017

@Benaiah funny, I thought I had discussed it with you before too, must have just been in Gitter 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants