Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 5 #423

Closed
chrbala opened this issue May 6, 2021 · 5 comments
Closed

Upgrade to webpack 5 #423

chrbala opened this issue May 6, 2021 · 5 comments
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@chrbala
Copy link

chrbala commented May 6, 2021

Is your feature request related to a problem? Please describe.
The most recent version of ts-loader does not work on Webpack 4.

Describe the solution you'd like
Upgrade to Webpack 5

Describe alternatives you've considered
Only use older versions of webpack plugins that work with Webpack 4.

Additional context
This is a breaking change, so it should be a major version upgrade to netlify-lambda.

@chrbala chrbala added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 6, 2021
@erezrokah
Copy link
Contributor

Hi @chrbala, while we consider this feature request, I recommend trying out our new esbuild based bundler:
https://www.netlify.com/blog/2021/04/02/modern-faster-netlify-functions/
as it supports TypeScript and new ECMAScript features out of the box (I'm assuming that's the reason you're using netlify-lambda).

@bpinto
Copy link

bpinto commented Aug 7, 2021

I'd love to see support for webpack 5 as well.

I believe gatsby v3 requires webpack 5. So using a different tool (esbuild) when using netlify + gatsby might not be ideal.

Is there an existing work for making this project webpack 5 compatible?

@bpinto bpinto mentioned this issue Aug 18, 2021
1 task
@SupersonicMagpie
Copy link

SupersonicMagpie commented Oct 14, 2021

any updates on this? I see that PR is ready, why not to merge it? @erezrokah

@erezrokah
Copy link
Contributor

Hi all 👋 Very sorry for the delay on this.
Since moving to Webpack 5 removes some functionally (the merge.smart logic), we'll need to do some manual testing on the PR to see the impact. I haven't been able to do it (yet).

So it's not only about the code changes, more about their impact on existing users. We'll do it as a major version bump anyway, since it's a breaking change, but if there's anything we can do to make it easier for users to migrate or understand the breakage - it would be better to understand that in advance (and document it).

One thing you can do to help is to try running with the suggested change (either by forking or by installing directly from the PR branch), and see the impact.
That would help us understand the impact on existing users.

@arsinclair
Copy link

Any update here? It's all very quiet.

@danez danez closed this as completed Feb 13, 2023
@netlify netlify locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants