Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce summary sent to only id and score #448

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

kevinsamoei
Copy link
Contributor

@kevinsamoei kevinsamoei commented Aug 1, 2022

To reduce the processing work to be done for this data, it will be neat to just send what we need. This only affects what we send as part of extraData

This basically changes:

[
    { title: 'Performance', score: 1, id: 'performance', threshold: 0.5 },
    { title: 'Accessibility', score: 1, id: 'accessibility' },
    { title: 'Best Practices', score: 1, id: 'best-practices' },
    { title: 'SEO', score: 0.91, id: 'seo' },
    { title: 'PWA', score: 0.3, id: 'pwa' }
]

to

{   
  "performance": 100, "accessibility": 100, "best-practices": 100, "seo": 91,  "pwa": 30                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             
}

@kevinsamoei kevinsamoei requested a review from a team August 1, 2022 14:19
@netlify
Copy link

netlify bot commented Aug 1, 2022

👷 Deploy Preview for plugin-lighthouse processing.

Name Link
🔨 Latest commit 9ad4ffb
🔍 Latest deploy log https://app.netlify.com/sites/plugin-lighthouse/deploys/62e7ead7e51efb00084016fc

@kevinsamoei kevinsamoei changed the title Reduce summary sent to only id and score feat: reduce summary sent to only id and score Aug 1, 2022
src/index.js Outdated Show resolved Hide resolved
kevinsamoei and others added 2 commits August 1, 2022 17:58
Co-authored-by: Nasiba Carrasco Lanchas <nasivuela@gmail.com>
@nasivuela nasivuela self-requested a review August 1, 2022 15:21
@kevinsamoei kevinsamoei merged commit 969cc58 into main Aug 1, 2022
@kevinsamoei kevinsamoei deleted the reduce-summary-to-id-and-score branch August 1, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants