New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware should merge API route response cookies #1797

Closed

ascorbic opened this issue Nov 22, 2022 · 2 comments · Fixed by #1870

Assignees

Member

ascorbic commented Nov 22, 2022

Currently, calling res.cookies.set in middleware replaces any cookies set by an API route. Instead they should be merged.

e2e test: skip-trailing-slash-redirect

The text was updated successfully, but these errors were encountered:

Contributor

taty2010 commented Dec 15, 2022

Test:
https://github.com/netlify/next-runtime/blob/e02c2b7e5555805d499b541feda2dbbf94da4a4f/test/e2e/modified-tests/skip-trailing-slash-redirect/index.test.ts

App:
https://github.com/netlify/next-runtime/blob/e02c2b7e5555805d499b541feda2dbbf94da4a4f/test/e2e/modified-tests/skip-trailing-slash-redirect/app/pages/api/test-cookie.js

https://github.com/netlify/next-runtime/blob/e02c2b7e5555805d499b541feda2dbbf94da4a4f/test/e2e/modified-tests/skip-trailing-slash-redirect/app/middleware.js

Member Author

ascorbic commented Dec 16, 2022

The specific test is this one, which you can enable by setting RUN_SKIPPED_TESTS

taty2010 self-assigned this

taty2010 mentioned this issue

fix: merge Middleware and API route response cookies #1870

Merged

2 tasks

kodiakhq bot closed this as completed in #1870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment