This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: create symlink parent directory before creating symlink itself #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 9e82c5a largeDepsEsbuild: 1.5s⬇️ 0.43% decrease vs. 9e82c5a Legend
largeDepsNft: 5.8s⬆️ 2.58% increase vs. 9e82c5a Legend
largeDepsZisi: 10.7s⬆️ 1.06% increase vs. 9e82c5a Legend
|
eduardoboucas
approved these changes
Feb 14, 2024
Skn0tt
added a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…etlify/zip-it-and-ship-it#1709) * fix: don't swallow beginning of path * chore: add repro * fix: create link parent directory before creating link
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes netlify/cli#6106, https://linear.app/netlify/issue/COM-351/esm-dependencies-in-v2-functions-in-pnpm-repo-cause-crash-in-dev.
For
includedFiles, we're recreating symlinks, sometimes in nested paths. Sometimes this breaks because the target directory doesn't exist. This PR fixes that by ensuring that a symlinks containing directory is created before the symlink itself is created.For us to review and ship your PR efficiently, please perform the following steps:
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)