Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL Processing for nmdb-import-cisco #4

Closed
marshall-sg opened this issue Mar 16, 2020 · 3 comments · Fixed by #14
Closed

ACL Processing for nmdb-import-cisco #4

marshall-sg opened this issue Mar 16, 2020 · 3 comments · Fixed by #14
Assignees
Labels
Enhancement Enhance existing tool for end user.
Projects

Comments

@marshall-sg
Copy link
Collaborator

marshall-sg commented Mar 16, 2020

Is your enhancement request related to a problem? Please describe.
The nmdb-import-cisco tool should be able to appropriately parse ACLs. Currently only the ASA one does this.

Describe the solution you'd like
The nmdb-import-cisco tool process ACL lists similar to how the ASA one does.

Describe alternatives you've considered
Attempted to process with the ASA parser, but it appears not to work appropriately. Manual insertions was the only other option via the nmdb-insert-ac tool.

@marshall-sg marshall-sg added the Enhancement Enhance existing tool for end user. label Mar 16, 2020
@marshall-sg marshall-sg changed the title Cisco ACL Processing ACL Processing for nmdb-import-cisco Mar 27, 2020
@marshall-sg marshall-sg changed the title ACL Processing for nmdb-import-cisco ACL Processing for nmdb-import-cisco Mar 27, 2020
@marshall-sg marshall-sg added this to In progress in FC#001 Mar 27, 2020
@marshall-sg marshall-sg added this to the test milestone Mar 31, 2020
@marshall-sg marshall-sg moved this from In progress to WIP: Week in FC#001 Mar 31, 2020
@marshall-sg marshall-sg moved this from WIP: Week to WIP: Today in FC#001 Mar 31, 2020
@marshall-sg marshall-sg removed this from the test milestone Mar 31, 2020
@marshall-sg marshall-sg moved this from WIP: Today to WIP: Week in FC#001 Mar 31, 2020
@marshall-sg marshall-sg moved this from WIP: Week to WIP: Today in FC#001 Mar 31, 2020
@marshall-sg marshall-sg moved this from WIP: Today to WIP: Week in FC#001 Mar 31, 2020
@cctechwiz
Copy link
Contributor

cctechwiz commented Apr 3, 2020

Code complete.

Troubleshooting regression test issues that master branch is throwing an error running nmdb-import-cisco.

$ nmdb-import-cisco --device-id test ../Running.Config -v 8
ERROR: option '--data-path' cannot be specified more than once

All nmdb-import-cisco* parsers are doing this when provided with a --device-id flag. If you omit that flag, it runs properly. Running --help does not show --device-id as an options for those parsers.

Checking the parser tool code, the device-id was in fact removed in modifyToolOptions. This makes me very curious as to when my branch was made and how it doesn't reflect that change since there are no commits since V2.0 that makes that change.


Ok. This was introduced much earlier on this branch. So there is no way currently that the master branch will run against the regression tests at all. I will need to regress against another point, if at all.

@cctechwiz cctechwiz moved this from WIP: Week to Done in FC#001 Apr 3, 2020
@marshall-sg
Copy link
Collaborator Author

marshall-sg commented Apr 6, 2020

I think you need to regress with c5472c1 installed. That appears to be the last commit I was changing stuff that would impact the regression testing.

@marshall-sg marshall-sg moved this from Done to WIP: Week in FC#001 Apr 7, 2020
@marshall-sg
Copy link
Collaborator Author

I moved it back from done. It needs an approved and merged pull request before it can be considered done.

@marshall-sg marshall-sg moved this from WIP: Week to Done in FC#001 Apr 14, 2020
@marshall-sg marshall-sg moved this from Done to WIP: Week in FC#001 Apr 14, 2020
@marshall-sg marshall-sg moved this from WIP: Week to Done in FC#001 Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance existing tool for end user.
Projects
FC#001
  
Complete Issues
Development

Successfully merging a pull request may close this issue.

2 participants