Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision label in filename #50

Closed
Reshad-Rahman opened this issue Mar 19, 2020 · 3 comments
Closed

Revision label in filename #50

Reshad-Rahman opened this issue Mar 19, 2020 · 3 comments
Assignees
Labels
updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft) yang-semver-soln Issues that apply to yang-semver (yang semver solution draft)

Comments

@Reshad-Rahman
Copy link
Collaborator

From Martin Bjorklund on draft-ietf-netmod-yang-module-versioning-00:

o 3.3

  In the filename of a YANG module, where it takes the form: module-
  or-submodule-name ['@' revision-label] ( '.yang' / '.yin' )

Should this section update 5.2 of RFC 7950? I know that 5.2 just
says "SHOULD". But existing tools implement this SHOULD, and they
need to be updated to handle this new convention.

But I wonder if this a good idea. It means that a tool that looks
for a module with a certain revision date cannot simply check the
filenames, but need to parse all available modules

@Reshad-Rahman Reshad-Rahman added the updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft) label Mar 19, 2020
@xorrkaz xorrkaz added the yang-semver-soln Issues that apply to yang-semver (yang semver solution draft) label Mar 20, 2020
@Reshad-Rahman
Copy link
Collaborator Author

We agree that there is an impact on searching by date. We put this in to have the ability to search by revision-label, otherwise we can search just by date for a module which uses revision-label.
We had also discussed using different limiter for the label and have something along the lines of: module-or-submodule-name['@'date]['#'revision-label].yang
It'd seem that updating 7950 would be a good idea whichever way we go.

@Reshad-Rahman
Copy link
Collaborator Author

Reshad-Rahman commented Jun 22, 2020

Latest discussions is to have 2 filenames with same content (may use symlink):
module-or-submodule-name['@'date].yang (unchanged)
module-or-submodule-name['#'revision-label].yang (new)

Last paragraph of 3.3 has to be updated too.

@Reshad-Rahman
Copy link
Collaborator Author

2 filenames (@ with date, # with revision-label) can be used as per section 3.3 of https://www.ietf.org/id/draft-ietf-netmod-yang-module-versioning-01.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
updated-mod-rev-handling Issues related to yang-module-versioning (updated module revision handling draft) yang-semver-soln Issues that apply to yang-semver (yang semver solution draft)
Projects
None yet
Development

No branches or pull requests

2 participants