Turn off forced GC by default

[jotak]

Also rename EnableGC => ForceGC (GC is never disabled)

This should improve CPU usage at the expanse of memory, but memory is supposed to be capped with GOMEMLIMIT (which also triggers GC when reached) so this shouldn't be worrying

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

/hold

holding for perf tests

[codecov]

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (2eae149) 39.51% compared to head (561ef60) 39.51%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   39.51%   39.51%           
=======================================
  Files          31       31           
  Lines        2394     2394           
=======================================
  Hits          946      946           
  Misses       1391     1391           
  Partials       57       57           

Flag	Coverage Δ
unittests	39.51% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
pkg/flow/tracer_ringbuf.go	21.87% <50.00%> (ø)
pkg/flow/tracer_map.go	78.57% <83.33%> (ø)
pkg/agent/agent.go	37.84% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msherif1234]

/lgtm

[jotak]

closing in favor of #185