Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDK does not properly wait for initialization #168

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Mar 29, 2024

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 37.93103% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 91.73%. Comparing base (702ca34) to head (0dc105e).

Files Patch % Lines
Sources/ParseSwift/Objects/ParseInstallation.swift 35.71% 9 Missing ⚠️
Sources/ParseSwift/Objects/ParseUser.swift 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   91.79%   91.73%   -0.06%     
==========================================
  Files         178      178              
  Lines       15802    15830      +28     
==========================================
+ Hits        14505    14522      +17     
- Misses       1297     1308      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 linked an issue Mar 30, 2024 that may be closed by this pull request
@cbaker6 cbaker6 merged commit 9b7a960 into main Apr 1, 2024
13 of 14 checks passed
@cbaker6 cbaker6 deleted the waitOnInit branch April 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensuring initialize has returned before attempting queries.
1 participant