Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for supporting Swift 5.5 #132

Merged
merged 9 commits into from
Oct 6, 2021
Merged

Changes for supporting Swift 5.5 #132

merged 9 commits into from
Oct 6, 2021

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Oct 5, 2021

Some changes are needed to support Swift 5.5 and async/await

  • Refactor Task to PCKTask, this classes with Swift 5.5 introduction of Task. This name change is only reflected in the SDK. The server will still have the names without PCK. To prevent issues like this in the future, prepended all ParseCareKit class names with PCK
  • Add async/await wrappers
  • Add combine wrappers

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #132 (366fab1) into main (e78ae4c) will increase coverage by 0.57%.
The diff coverage is 33.98%.

❗ Current head 366fab1 differs from pull request most recent head cd800d9. Consider uploading reports for the commit cd800d9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   13.34%   13.92%   +0.57%     
==========================================
  Files          14       16       +2     
  Lines        2001     2004       +3     
==========================================
+ Hits          267      279      +12     
+ Misses       1734     1725       -9     
Impacted Files Coverage Δ
Sources/ParseCareKit/Objects/PCKClock.swift 0.00% <0.00%> (ø)
...ParseCareKit/Protocols/PCKObjectable+combine.swift 0.00% <0.00%> (ø)
...arseCareKit/Protocols/PCKVersionable+combine.swift 0.00% <0.00%> (ø)
...ources/ParseCareKit/Protocols/PCKVersionable.swift 4.82% <0.00%> (+0.09%) ⬆️
Sources/ParseCareKit/Objects/PCKOutcome.swift 14.61% <16.66%> (ø)
Sources/ParseCareKit/ParseRemote.swift 2.60% <16.66%> (ø)
Sources/ParseCareKit/Objects/PCKContact.swift 17.61% <30.00%> (ø)
...ources/ParseCareKit/Objects/PCKHealthKitTask.swift 15.67% <30.00%> (ø)
Sources/ParseCareKit/Objects/PCKTask.swift 15.21% <30.00%> (ø)
Sources/ParseCareKit/Protocols/PCKObjectable.swift 35.71% <40.00%> (+8.54%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78ae4c...cd800d9. Read the comment docs.

@cbaker6 cbaker6 merged commit b080e59 into main Oct 6, 2021
@cbaker6 cbaker6 deleted the fixTask branch October 6, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant