Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve default ACL support #145

Merged
merged 11 commits into from
Nov 21, 2021
Merged

feat: improve default ACL support #145

merged 11 commits into from
Nov 21, 2021

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Nov 21, 2021

If the developer doesn't set a defaultACL for the objects being synced, create one for them.

  • Update to Parse-Swift 2.2.6
  • Allow a defaultACL to be set for ParseCareKit
  • Increase codecov

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #145 (5abcd3b) into main (2c17358) will increase coverage by 5.77%.
The diff coverage is 64.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   12.51%   18.28%   +5.77%     
==========================================
  Files          18       24       +6     
  Lines        2837     3029     +192     
==========================================
+ Hits          355      554     +199     
+ Misses       2482     2475       -7     
Impacted Files Coverage Δ
Sources/ParseCareKit/Objects/PCKClock.swift 0.00% <0.00%> (ø)
Sources/ParseCareKit/ParseCareKitConstants.swift 59.82% <ø> (ø)
Sources/ParseCareKit/ParseCareKitError.swift 0.00% <0.00%> (ø)
...ources/ParseCareKit/Protocols/PCKVersionable.swift 3.77% <ø> (ø)
Sources/ParseCareKit/Protocols/PCKObjectable.swift 33.33% <33.33%> (ø)
Sources/ParseCareKit/ParseRemote.swift 7.47% <40.98%> (+5.13%) ⬆️
Sources/ParseCareKit/Objects/PCKCarePlan.swift 14.72% <62.50%> (+1.23%) ⬆️
Sources/ParseCareKit/Objects/PCKContact.swift 17.81% <62.50%> (+1.08%) ⬆️
...ources/ParseCareKit/Objects/PCKHealthKitTask.swift 16.28% <62.50%> (+1.17%) ⬆️
Sources/ParseCareKit/Objects/PCKPatient.swift 13.77% <62.50%> (+1.44%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c17358...5abcd3b. Read the comment docs.

@cbaker6 cbaker6 merged commit e7cc516 into main Nov 21, 2021
@cbaker6 cbaker6 deleted the updateACL branch November 21, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant