Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove saving uuid on ParseCareKit objects #149

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Remove saving uuid on ParseCareKit objects #149

merged 1 commit into from
Dec 12, 2021

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Dec 12, 2021

  • The uuid of all ParseCareKit objects is now objectId
  • allowCustomObjectId has been abled on the client

Warning these updates are not backwards compatible with previous versions of parse-hipaa or ParseCareKit.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #149 (90b7cda) into main (54068c8) will increase coverage by 1.38%.
The diff coverage is 25.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   17.96%   19.35%   +1.38%     
==========================================
  Files          24       24              
  Lines        3150     2991     -159     
==========================================
+ Hits          566      579      +13     
+ Misses       2584     2412     -172     
Impacted Files Coverage Δ
Sources/ParseCareKit/Objects/PCKClock.swift 0.00% <0.00%> (ø)
Sources/ParseCareKit/ParseCareKitConstants.swift 59.82% <ø> (ø)
Sources/ParseCareKit/ParseRemote.swift 6.84% <0.00%> (ø)
...ources/ParseCareKit/Protocols/PCKVersionable.swift 3.70% <0.00%> (-0.07%) ⬇️
Sources/ParseCareKit/Objects/PCKCarePlan.swift 17.03% <33.33%> (+2.30%) ⬆️
Sources/ParseCareKit/Objects/PCKContact.swift 20.32% <33.33%> (+2.50%) ⬆️
...ources/ParseCareKit/Objects/PCKHealthKitTask.swift 18.80% <33.33%> (+2.51%) ⬆️
Sources/ParseCareKit/Objects/PCKOutcome.swift 14.20% <33.33%> (+1.40%) ⬆️
Sources/ParseCareKit/Objects/PCKPatient.swift 16.41% <33.33%> (+2.63%) ⬆️
Sources/ParseCareKit/Objects/PCKTask.swift 18.45% <33.33%> (+2.48%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54068c8...90b7cda. Read the comment docs.

@cbaker6 cbaker6 merged commit 73bff85 into main Dec 12, 2021
@cbaker6 cbaker6 deleted the removeUUID branch December 12, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant