Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTE transformations RTE => DB hook transform_db uses uninitialized $this->procOptions #188

Closed
sypets opened this issue Oct 1, 2022 · 4 comments
Labels
php PHP related task TYPO3 v11

Comments

@sypets
Copy link
Contributor

sypets commented Oct 1, 2022

The function RteImagesDbHook::transform_db() is called from RteHtmlParser (as hook). Beforehand, a new instance is created and the configuration $this->procOptions is not initialized.

You can confirm this by debugging and setting a breakpoint in the function and checking the content of $this->procOptions and comparing the content when a breakpoint is set in RteHtmlParser::transformTextForPersistence().

System

  • TYPO3 11.5.16
  • rte_ckeditor_image: v11.0.5
@sypets
Copy link
Contributor Author

sypets commented Oct 1, 2022

Also, the hook is deprecated in v11 and will be removed in TYPO3 v12.

See related:

deprecation:

removal:

@CybotTM CybotTM changed the title RTE transformations RTE => DB hook transform_db uses uniniitalized $this->procOptions RTE transformations RTE => DB hook transform_db uses uninitialized $this->procOptions Nov 16, 2022
@magicsunday magicsunday added php PHP related task TYPO3 v11 labels Jan 21, 2023
@magicsunday
Copy link
Member

magicsunday commented Aug 10, 2023

@sypets

Seems outdated to me. Can you confirm that this error has already been fixed? Some things have been modified on the RteImagesDbHook in the meantime.

@sypets
Copy link
Contributor Author

sypets commented Feb 23, 2024

I am closing. v12 is now supported and function no longer used in latest main. Sorry about late reply.

@sypets sypets closed this as completed Feb 23, 2024
@CybotTM
Copy link
Member

CybotTM commented Feb 26, 2024

Yes, this is fixed with 34a65f3 - I was not aware of this issue here, otherwise I had linked it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php PHP related task TYPO3 v11
Projects
None yet
Development

No branches or pull requests

3 participants