Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Fragment Implementation #6

Closed
john-bv opened this issue Aug 9, 2021 · 3 comments
Closed

Complete Fragment Implementation #6

john-bv opened this issue Aug 9, 2021 · 3 comments
Assignees
Labels
Complete The code review for this issue has been completed; and is now being finalized.

Comments

@john-bv
Copy link
Member

john-bv commented Aug 9, 2021

The following implementation is incorrect and buggy: https://github.com/NetrexMC/RakNet/tree/fragments/src/frame/mod.rs#L161-L180

Why?
We receive a large frame from the client, but the fragments are incorrectly reassembled by the fragment list.

I will investigate this more tomorrow.

This issue is high priority because when it is fixed, we will be able to actually work on the software.

@john-bv john-bv self-assigned this Aug 9, 2021
@john-bv
Copy link
Member Author

john-bv commented Aug 10, 2021

As per commit: a8de253, implementation is wrong, fragments are a single "frame" or packet, not a framepacket. should fix asap.

@john-bv
Copy link
Member Author

john-bv commented Oct 23, 2021

I believe this has also been resolved, however I will investigate further to make sure.

@john-bv
Copy link
Member Author

john-bv commented Jan 9, 2022

This issue has been fixed to my knowledge by a commit in v0.1.x.

@john-bv john-bv closed this as completed Jan 9, 2022
@john-bv john-bv added the Complete The code review for this issue has been completed; and is now being finalized. label Jun 17, 2023
@NetrexMC NetrexMC locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complete The code review for this issue has been completed; and is now being finalized.
Projects
None yet
Development

No branches or pull requests

1 participant