Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] netscaler.adc.lbmonitor module logs nitro pass. no_log is not set in this module #286

Closed
QTjstahl opened this issue Sep 29, 2023 · 1 comment · Fixed by #290
Closed
Assignees

Comments

@QTjstahl
Copy link

QTjstahl commented Sep 29, 2023

Describe the bug
The module netscaler.adc.lbmonitor apparently does not have the "no_log" option set. As a result, it logs the password and warnings are given upon execution.

To Reproduce
Steps to reproduce the behaviour:
Use the netscaler.adc.lbmonitor module to create a new custom monitor. My task is as follows:

  - name: Create TFTP Custom Monitor for Auto Deploy
    delegate_to: localhost
    netscaler.adc.lbmonitor:
      nitro_user: "{{ nitro_user }}"
      nitro_pass: "{{ nitro_pass }}"
      nsip: "{{ nsip }}"
      validate_certs: no

      monitorname: AutoDeployTFTP_Monitor
      state: present
      type: USER
      interval: 5
      resptimeout: 2
      scriptname: "nstftp.pl"
      scriptargs: "file=tramp;content=#!gpxe"
  1. The ansible-playbook command I executed is...
    ansible-playbook netscaler.yml

  2. The ansible-playbook logs are...

TASK [Create TFTP Custom Monitor for Auto Deploy] ************************************************************************
[WARNING]: Module did not set no_log for password
ok: [XXX.XXX.XXX.XXX -> localhost]
  1. I am seeing the below error...
[WARNING]: Module did not set no_log for password

Expected behaviour
I expected to not see the "no_log" warning and for the password to not be logged. All other modules have "no_log" set.

Environment (please complete the following information):

  • Python version python --version output
    • python3 --version Python 3.10.12
  • Ansible version ansible --version output
    -ansible 2.10.17
    config file = /home/USER/vsphere_auto_deploy/ansible.cfg
    configured module search path = ['/home/USER/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
    ansible python module location = /home/USER/.local/lib/python3.10/site-packages/ansible
    executable location = /home/USER/.local/bin/ansible
    python version = 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0]
  • NetScaler version show ns version output
    NetScaler NS13.1: Build 37.38.nc, Date: Nov 23 2022, 04:42:36 (64-bit)
@sumanth-lingappa
Copy link
Collaborator

Please install the latest unreleased collection to get the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants