Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ifpps: stats_diff error #74

Closed
jonschipp opened this issue Aug 28, 2013 · 7 comments
Closed

ifpps: stats_diff error #74

jonschipp opened this issue Aug 28, 2013 · 7 comments

Comments

@jonschipp
Copy link
Contributor

Ifpps throws an error after a few lines when I use a 10 second interval.
ifpps --dev eth2 --csv --loop --interval 10000

ifpps: ifpps.c:539: stats_diff: Assertion `!((new->rx_bytes - old->rx_bytes) > (new->rx_bytes))' failed.

@jonschipp
Copy link
Contributor Author

Actually, it's happening at other times too e.g. ifpps --dev eth2

ifpps: ifpps.c:563: stats_diff: Assertion `!((new->irqs[i] - old->irqs[i]) > (new->irqs[i]))' failed

@jonschipp
Copy link
Contributor Author

Ah, sorry, false alarm. I had a script bringing down the interface I forgot was running, at specific times. That was the cause.

@tklauser
Copy link
Member

Thanks for reporting this. Still, I think the bug_on() wouldn't be necessary in this case. We might be able to just reset the stats if the interface went down inbetween. I'll have a look...

@borkmann
Copy link
Contributor

Sounds good, bringing the interface down should not bring down ifpps. ;-) I think something like resetting the stats sounds like a good idea.

@tklauser
Copy link
Member

@jonschipp: Could you check whether the above commit fixes the issue for you? Thanks!

@borkmann
Copy link
Contributor

Thanks Tobias!

@jonschipp
Copy link
Contributor Author

Yes, thanks, I should now be able to avoid using "watch -n 1 'cat /proc/net/dev | column -t'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants