Problem inheriting from WebClientFileDownloader class and overriding CreateHttpClient method

[bdovaz]

In the 2 constructors of this class a virtual method is invoked (PrepareToDownloadFile > CreateHttpClient) and this is not good practice and is causing me problems:

NetSparkle/src/NetSparkle/Downloaders/WebClientFileDownloader.cs

Line 36 in 225fb7b

PrepareToDownloadFile();

In sonar you can see why it should not be done and that it is just my exact problem:

https://rules.sonarsource.com/csharp/RSPEC-1699/?search=virtual

[Deadpikle]

Thanks for the heads up! Fixed in 420f961 and preview version rolling out now.