ids not generated for hidden inputs

[bazo]

in latest dev-master, hidden inputs have no html ids.

before we had e.g. frm-documentEditor-form-items now there's nothing

is this a bug or a new feature? it breaks all legacy js that works with these generated ids in our app

would suck big time to hunt down all hidden fields that are being used somewhere in js and manually change them

[dg]

To look in history https://github.com/nette/forms/commits/master/src/Forms/Controls/HiddenField.php is probably faster that to create this issue.

It is experimental.

[vojtech-dobes]

Once again it becomes clear that dependency on generated IDs is good candidate for refactoring :).

[vysinsky]

Once again it becomes clear that dependency on generated IDs is good candidate for refactoring :).

👍

[bazo]

well, tell to that guy who coded that before me :) refactoring is best done one step at a time, not all at once

btw, what's the reason for this change? i don't think it helps anything or that it would be problematic. it's just harmless and i would guess there would more apps out there that depend on it

i'm for keeping it, like it was in 2.2

[bazo]

btw, $form['items']->getHtmlId() still returns the generated id, shouldn't it return NULL then?

[mishak87]

@bazo Did that guy also decided to migrate code instead to next stable to @dev again or was that you?

[bazo]

and how is that relevant? that was an answer to vojtech. i've already fixed that.
but i'm just asking what advantage this change has?