Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper formatting of long subjects. #1437

Closed
wants to merge 2 commits into from

Conversation

petrkle
Copy link
Contributor

@petrkle petrkle commented Mar 6, 2014

Under Windows Message::EOL and PHP_EOL are same and everything work fine. But in Linux \r\n is replaced by \n and long subjects are send in wrong format.

@hrach
Copy link
Contributor

hrach commented Mar 7, 2014

Could you please add test?

@Majkl578
Copy link
Contributor

Majkl578 commented Mar 7, 2014

long subjects are send in wrong format

In what way? Does it break any RFC?

@petrkle
Copy link
Contributor Author

petrkle commented Mar 7, 2014

In what way? Does it break any RFC?

In RFC822 are parts of long headers divided by CRLF.

@dg
Copy link
Member

dg commented Mar 12, 2014

In this case testing is IMHO impossible.

Emails uses only CRLF, but Unix mail replaces LF by CRLF automatically, which leads to doubling CR if CRLF is used. See http://cz1.php.net/manual/en/function.mail.php

According to PHP source codes, Subject + To must contain CRLF. Can you fix "To" too?

@dg dg closed this in c3e78cc Mar 12, 2014
dg pushed a commit to nette/mail that referenced this pull request Mar 13, 2014
dg pushed a commit to nette/mail that referenced this pull request Mar 18, 2014
@janedbal
Copy link

This commit caused me problems when recieving sending emails from wedos mailserver to some webservers (gmail seems ok). It trimmes the subject after several characters and the content of email is displayed as RAW contents of email message (with headers, boundaries, ...)

Is this problem on wedos mailserver or is it possible, that the solution is not 100% correct?

@icaine
Copy link

icaine commented Apr 17, 2014

@CasperN confirming the problem.. Some of our clients receive base64 chars instead of attachments. Reverting to the version with str_replace fixed it.

@hrach
Copy link
Contributor

hrach commented Apr 18, 2014

Reopening the issue.

@hrach hrach reopened this Apr 18, 2014
@dg
Copy link
Member

dg commented Apr 18, 2014

It is related to "subject" or "to" parameter?

@icaine
Copy link

icaine commented Apr 18, 2014

Seems its subject related problem (http://i.imgur.com/IvCRbUf.png)

dg added a commit to nette/mail that referenced this pull request Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants