Method isControlInvalid does not "see" through ComponentContainer

[JanTvrdik]

If a component is not a direct descendant (in component tree) of presenter but is a child of ComponentContainer (which is child of some presenter) then after component invalidation the presenter is not invalidated even though it should be because method isControlInvalid does not "go through" ComponentContainer (because it does not implement IRenderable).

[dg]

Any fix?

[JanTvrdik]

This may work but I haven't tested it because I need to study for exams which I'm about to write in few hours.

public function isControlInvalid($snippet = NULL)
{
    if ($snippet === NULL) {
        if (count($this->invalidSnippets) > 0) {
            return TRUE;

        } else {
            $queue = array($this);
            do {
                foreach (array_shift($queue)->getComponents() as $component) {
                    if ($component instanceof IRenderable) {
                        if ($component->isControlInvalid()) {
                            // $this->invalidSnippets['__child'] = TRUE; // as cache
                            return TRUE;
                        }

                    } elseif ($component instanceof Nette\ComponentModel\IContainer) {
                        $queue[] = $component;                          
                    }
                }
            } while ($queue);

            return FALSE;
        }

    } else {
        return isset($this->invalidSnippets[NULL]) || isset($this->invalidSnippets[$snippet]);
    }
}

[JanTvrdik]

I have found a bit of time to test the fix which was suggested above and it seems to be fine. And managed to convert this issue to pull request.

[dg]

And what about foreach ($this->getComponents(TRUE) as $component)?

[JanTvrdik]

That will iterate also over children of classes which implements IRenderable and that is not necessary.