Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nette Tester - set PHP CLI automatically #100

Closed
tmysik opened this issue Feb 18, 2014 · 8 comments
Closed

Nette Tester - set PHP CLI automatically #100

tmysik opened this issue Feb 18, 2014 · 8 comments

Comments

@tmysik
Copy link

tmysik commented Feb 18, 2014

cc @milo

Hi,
please, could anyone have a look at [1] and let me know whether it makes sense or not? I tend to close that issue as INVALID but would like to know your opinion.

Thanks!
[1] https://netbeans.org/bugzilla/show_bug.cgi?id=241996

@milo
Copy link
Member

milo commented Feb 18, 2014

@tmysik Related to #1. Main reason is that only CGI prints HTTP headers which are needed for some tests. It can be easily switched by -p php.

@dg
Copy link
Member

dg commented Feb 19, 2014

In all PHP packages for Windows there are php.exe, php-cgi.exe and php-win.exe, so it does not matter which one is default. But, how is it on Linux?

@hrach
Copy link

hrach commented Feb 19, 2014

apt-get install php5 does not install php5-cli nor php5-fpm nor php5-cgi.

@dg
Copy link
Member

dg commented Feb 19, 2014

So that php can be default. But it is BC break.

@tmysik
Copy link
Author

tmysik commented Feb 19, 2014

And what do you think about the reported NetBeans issue I mentioned before? Likely adding a checkbox Use PHP Interpreter as default could solve it, right? It would be perhaps checked by default so it works for most of the users.

Thanks.

@milo
Copy link
Member

milo commented Feb 19, 2014

@tmysik In general, anyone may need to use different PHP binary for running the test. What about add new input in Options or Project Properties named PHP binary for tests with default value php-cgi (without path). If filled, call the Tester with -p ... argument?

@tmysik
Copy link
Author

tmysik commented Feb 19, 2014

@milo Yes, that would be better than my proposal. I need to find out whether I can do it or whether it is too late for NB 8.0.

Thank you all for your comments!

@tmysik tmysik closed this as completed Feb 19, 2014
@tmysik
Copy link
Author

tmysik commented Apr 25, 2014

FYI issue [1] is fixed now - it is possible to set default executable in IDE Options as well as in Project Properties.

Thanks.
[1] https://netbeans.org/bugzilla/show_bug.cgi?id=241996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants