bar: replaced attribute 'rel' with 'data-tracy-action' for closing & …

…open-to-window links
nette · Apr 8, 2019 · bca664d · bca664d
1 parent 843c47c
commit bca664d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/Tracy/Bar/assets/bar.js b/src/Tracy/Bar/assets/bar.js
@@ -62,9 +62,9 @@
 
 			elem.querySelectorAll('.tracy-icons a').forEach((link) => {
 				link.addEventListener('click', (e) => {
-					if (link.rel === 'close') {
+					if (link.dataset.tracyAction === 'close') {
 						this.toPeek();
-					} else if (link.rel === 'window') {
+					} else if (link.dataset.tracyAction === 'window') {
 						this.toWindow();
 					}
 					e.preventDefault();
@@ -258,7 +258,7 @@
 		initTabs(elem) {
 			elem.querySelectorAll('a').forEach((link) => {
 				link.addEventListener('click', (e) => {
-					if (link.rel === 'close') {
+					if (link.dataset.tracyAction === 'close') {
 						this.close();
 
 					} else if (link.rel) {
@@ -284,7 +284,7 @@
 				});
 
 				link.addEventListener('mouseenter', (e) => {
-					if (e.buttons || !link.rel || link.rel === 'close' || elem.classList.contains('tracy-dragged')) {
+					if (e.buttons || !link.rel || elem.classList.contains('tracy-dragged')) {
 						return;
 					}
 
@@ -311,7 +311,7 @@
 				link.addEventListener('mouseleave', () => {
 					clearTimeout(this.displayTimeout);
 
-					if (link.rel && link.rel !== 'close' && !elem.classList.contains('tracy-dragged')) {
+					if (link.rel && !elem.classList.contains('tracy-dragged')) {
 						Debug.panels[link.rel].blur();
 					}
 				});

diff --git a/src/Tracy/Bar/assets/bar.phtml b/src/Tracy/Bar/assets/bar.phtml
@@ -32,6 +32,6 @@ namespace Tracy;
 <?php } endforeach ?>
 
 <?php if ($type === 'main'): ?>
-	<li><a href="#" rel="close" title="close debug bar">&times;</a></li>
+	<li><a href="#" data-tracy-action="close" title="close debug bar">&times;</a></li>
 <?php endif ?>
 </ul>
diff --git a/src/Tracy/Bar/assets/panels.phtml b/src/Tracy/Bar/assets/panels.phtml
@@ -18,8 +18,8 @@ use Tracy\Helpers;
 
 $icons = '
 	<div class="tracy-icons">
-		<a href="#" rel="window" title="open in window">&curren;</a>
+		<a href="#" data-tracy-action="window" title="open in window">&curren;</a>
-		<a href="#" rel="close" title="close window">&times;</a>
+		<a href="#" data-tracy-action="close" title="close window">&times;</a>
 	</div>
 ';
 

diff --git a/tests/Tracy/expected/Debugger.barDump().expect b/tests/Tracy/expected/Debugger.barDump().expect
@@ -17,6 +17,6 @@ in file %a% on line %d%" data-tracy-href="editor:%a%"><span class="tracy-dump-st
 
 
 	<div class="tracy-icons">
-		<a href="#" rel="window" title="open in window">&curren;</a>
+		<a href="#" data-tracy-action="window" title="open in window">&curren;</a>
-		<a href="#" rel="close" title="close window">&times;</a>
+		<a href="#" data-tracy-action="close" title="close window">&times;</a>
 	</div>