Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CRS stuff #7

Closed
airbreather opened this issue Jun 19, 2019 · 2 comments · Fixed by #8
Closed

Remove CRS stuff #7

airbreather opened this issue Jun 19, 2019 · 2 comments · Fixed by #8
Labels
breaking change Doing this would break either source or binary compatibility with existing versions.

Comments

@airbreather
Copy link
Member

RFC 7946 GeoJSON doesn't have special recognition for it anymore, and it makes things awkward because it's kinda redundant with Geometry.SRID.
@airbreather airbreather added the breaking change Doing this would break either source or binary compatibility with existing versions. label Jun 19, 2019
airbreather added a commit that referenced this issue Jul 28, 2019
@airbreather
Updates for v2.
c00e9a6 
- All CoordinateSystems types are gone (resolves #7)
- (I)AttributesTable is gone, in favor of bare Dictionary<string, object> (resolves #6) (resolves #3)
- FeatureCollection now inherits from Collection<Feature>
- [Serializable] is now implemented via ISerializable
@airbreather airbreather mentioned this issue Jul 28, 2019
Merged
@FObermaier
Copy link
Member

I support this.

airbreather added a commit that referenced this issue Aug 23, 2019
@airbreather
Updates for v2. (#8)
3fd48b7 
- All CoordinateSystems types are gone (resolves #7)
- The extension methods dealing with ID values on IFeature instances are gone
    - to be moved to GeoJSON
- (I)AttributesTable now has GetOptionalValue (resolves #3)
- FeatureCollection now inherits from Collection<Feature>
- [Serializable] is now implemented via ISerializable
@steveoh
Copy link

steveoh commented May 12, 2020

I think this is a mistake

However, where all involved parties have a prior arrangement, alternative coordinate reference systems can be used without risk of data being misinterpreted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Doing this would break either source or binary compatibility with existing versions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates for v2. NetTopologySuite/NetTopologySuite.Features
3 participants
@steveoh @FObermaier @airbreather