Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsSql2008GeographyWriter has issue with internal polygon rings #2

Closed
wicksell opened this issue May 17, 2019 · 2 comments
Closed

MsSql2008GeographyWriter has issue with internal polygon rings #2

wicksell opened this issue May 17, 2019 · 2 comments

Comments

@wicksell
Copy link

In MsSql2008GeographyWriter.cs the following line
Array.ForEach(polygon.InteriorRings, ring => AddCoordinates(builder, TryReverseRing((ILinearRing)polygon.ExteriorRing, false).CoordinateSequence));
(in AddPolygon) should be replaced with
Array.ForEach(polygon.InteriorRings, ring => AddCoordinates(builder, TryReverseRing((ILinearRing)ring, false).CoordinateSequence));
@wicksell wicksell changed the title MsSql2008GeographyWriter as issue with internal polygon rings MsSql2008GeographyWriter has issue with internal polygon rings May 17, 2019
@airbreather
Copy link
Member

airbreather commented May 17, 2019 •
edited
Loading

Good call, I'll get it fixed.

FYI, I'd recommend using NetTopologySuite.IO.SqlServerBytes instead of this for new work where applicable.

@wicksell
Copy link
Author

OK, thanks for the feedback!

airbreather added a commit that referenced this issue May 17, 2019
@airbreather
Get tests running (with fixed connection string).
6be52ef 
As it turns out, the tests actually catch #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wicksell @airbreather