Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality of ICoordinateSystem instances #47

Open
afroewis opened this issue Jun 26, 2019 · 0 comments
Open

Equality of ICoordinateSystem instances #47

afroewis opened this issue Jun 26, 2019 · 0 comments

Comments

@afroewis
Copy link

Hi,

I noticed an unexpected behavior when working with this library. I tried to check whether 2 coordinate systems are the same:

var crs1 = GeographicCoordinateSystem.WGS84;
var crs2 = GeographicCoordinateSystem.WGS84;

crs1 == crs2; // False
crs1.Equals(crs2) // False

Since coordinate systems are reference types, I think it makes sense that crs1 != crs2 if they don't refer to the same reference. However, since the contents of crs1 and crs2 are the same, I think it would make sense if crs1.Equals(crs2) is true.

Is this behavior desired? If not, I'd be happy to create a pull request (if that's possible for backwards compatibility reasons?).

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants