Tests: Mockery, better structure, constants, ContainerHelperTest

composer.json

@@ -19,7 +19,8 @@
   },
   "require-dev": {
     "ninjify/qa": "~0.7.0",
-    "phpunit/phpunit": "^7.0.2"
+    "phpunit/phpunit": "^7.0.2",
+    "mockery/mockery": "^1.0"
   },
   "autoload": {
     "psr-4": {
@@ -28,13 +29,13 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "Tests\\Nettrine\\Migrations\\": "tests/"
+      "Tests\\Nettrine\\Migrations\\": "tests/cases/"
     }
   },
   "scripts": {
     "qa": [
-      "linter src tests",
-      "codesniffer src tests"
+      "linter src tests/cases",
+      "codesniffer src tests/cases"
     ],
     "phpunit": [
       "phpunit tests --colors=always"

ruleset.xml

@@ -7,7 +7,7 @@
         <properties>
             <property name="rootNamespaces" type="array" value="
                 src=>Nettrine\Migrations,
-                tests=>Tests\Nettrine\Migrations,
+                tests/cases=>Tests\Nettrine\Migrations,
             "/>
         </properties>
     </rule>

src/DI/MigrationsExtension.php

@@ -96,13 +96,12 @@ public function beforeCompile(): void
 
 		// Register console helper only if console is provided
 		$application = $builder->getByType(Application::class, FALSE);
-		if (!$application) {
-			return;
+		if ($application) {
+			$applicationDef = $builder->getDefinition($application);
+			$applicationDef->addSetup(
+				new Statement('$service->getHelperSet()->set(?)', [$this->prefix('@configurationHelper')])
+			);
 		}
-		$applicationDef = $builder->getDefinition($application);
-		$applicationDef->addSetup(
-			new Statement('$service->getHelperSet()->set(?)', [$this->prefix('@configurationHelper')])
-		);
 	}
 
 }

tests/DI/MigrationsExtensionTest.php → tests/cases/DI/MigrationsExtensionTest.php

@@ -8,8 +8,8 @@
 use Nette\DI\ContainerLoader;
 use Nettrine\Migrations\ContainerAwareConfiguration;
 use Nettrine\Migrations\DI\MigrationsExtension;
-use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Application;
+use Tests\Nettrine\Migrations\TestCase;
 
 final class MigrationsExtensionTest extends TestCase
 {
@@ -19,13 +19,13 @@ final class MigrationsExtensionTest extends TestCase
 	 */
 	public function testConsole(): void
 	{
-		$loader = new ContainerLoader(__DIR__ . '/temp', TRUE);
+		$loader = new ContainerLoader(TEMP_PATH, TRUE);
 		$class = $loader->load(function (Compiler $compiler): void {
 			// Required services and params
-			$compiler->loadConfig(__DIR__ . '/config/services.neon');
+			$compiler->loadConfig(FIXTURES_PATH . '/config/services.neon');
 			// Migrations
 			$compiler->addExtension('migrations', new MigrationsExtension());
-			$compiler->loadConfig(__DIR__ . '/config/default.neon');
+			$compiler->loadConfig(FIXTURES_PATH . '/config/default.neon');
 		}, 1);
 
 		/** @var Container $container */
@@ -45,13 +45,13 @@ public function testConsole(): void
 	 */
 	public function testWithoutConsole(): void
 	{
-		$loader = new ContainerLoader(__DIR__ . '/temp', TRUE);
+		$loader = new ContainerLoader(TEMP_PATH, TRUE);
 		$class = $loader->load(function (Compiler $compiler): void {
 			// Required services and params
-			$compiler->loadConfig(__DIR__ . '/config/services_without_console.neon');
+			$compiler->loadConfig(FIXTURES_PATH . '/config/services_without_console.neon');
 			// Migrations
 			$compiler->addExtension('migrations', new MigrationsExtension());
-			$compiler->loadConfig(__DIR__ . '/config/default.neon');
+			$compiler->loadConfig(FIXTURES_PATH . '/config/default.neon');
 		}, 2);
 
 		/** @var Container $container */

tests/cases/Helper/ConfigurationHelperTest.php

@@ -0,0 +1,39 @@
+<?php declare(strict_types = 1);
+
+namespace Tests\Nettrine\Migrations\Helper;
+
+use Doctrine\DBAL\Migrations\Configuration\Configuration;
+use Doctrine\DBAL\Migrations\OutputWriter;
+use Mockery;
+use Mockery\MockInterface;
+use Nettrine\Migrations\Helper\ConfigurationHelper;
+use Symfony\Component\Console\Input\InputInterface;
+use Tests\Nettrine\Migrations\TestCase;
+
+final class ConfigurationHelperTest extends TestCase
+{
+
+	/**
+	 * @return void
+	 */
+	public function testGetMigrationConfig(): void
+	{
+		/** @var InputInterface|MockInterface $input */
+		$input = Mockery::mock(InputInterface::class);
+		/** @var OutputWriter|MockInterface $outputWriter */
+		$outputWriter = Mockery::mock(OutputWriter::class);
+
+		$helper = new ConfigurationHelper();
+		self::assertNull($helper->getMigrationConfig($input, $outputWriter));
+
+		/** @var Configuration|MockInterface $configuration */
+		$configuration = Mockery::mock(Configuration::class)
+			->shouldReceive('setOutputWriter')
+			->withArgs([$outputWriter])
+			->getMock();
+
+		$helper = new ConfigurationHelper(NULL, $configuration);
+		self::assertSame($configuration, $helper->getMigrationConfig($input, $outputWriter));
+	}
+
+}

tests/cases/TestCase.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types = 1);
+
+namespace Tests\Nettrine\Migrations;
+
+use Mockery;
+use PHPUnit\Framework\TestCase as PHPUnitTestCase;
+
+abstract class TestCase extends PHPUnitTestCase
+{
+
+	/**
+	 * @return void
+	 */
+	protected function setUp(): void
+	{
+		parent::setUp();
+		if (!defined('TEMP_PATH')) {
+			define('TEMP_PATH', __DIR__ . '/../tmp');
+		}
+		if (!defined('FIXTURES_PATH')) {
+			define('FIXTURES_PATH', __DIR__ . '/../fixtures');
+		}
+	}
+
+	/**
+	 * @return void
+	 */
+	protected function tearDown(): void
+	{
+		Mockery::close();
+	}
+
+}