-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panicked at 'attempt to add with overflow' #210
Comments
I think this is same issue I have reported to @netvl privately. The function where integer overflow (and panic) occurs is Lines 483 to 491 in 9c82a76
where with certain input file (hex dump below), the match case '<' (line 486) causes integer overflow in d + 1, probably when d = 255. This case only panics when Rust's integer overflow checks are enabled, so usually in debug builds and not in release build. With release builds what probably happens is that the integer just silently overflows and things break in some other way. This is a hex dump of my test case (found and minimized by cargo fuzz):
|
Fixed |
with given input file:
in.zip
and following code:
output:
expect: properly return error instead of panic
The text was updated successfully, but these errors were encountered: