Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdtab systemd-mark #40

Closed
dsoul opened this issue Sep 30, 2016 · 2 comments
Closed

nbdtab systemd-mark #40

dsoul opened this issue Sep 30, 2016 · 2 comments

Comments

@dsoul
Copy link

dsoul commented Sep 30, 2016

It looks like nbdtab does not recognize systemd-mark as corresponding to -systemd-mark. man nbdtab says it's a bug :-). Just lost two days debugging every possible option in systemd why it kills nbd-client :-/

@yoe
Copy link
Member

yoe commented Oct 1, 2016

Well. It's a bug, but in the documentation.

It currently says "every option", but what it should say is "every option that can be used to set up a device". The -systemd-mark (or -m) option applies to the nbd-client process, not to the device. Similarly, the -list option also can't be specified in the nbdtab file, and that also isn't a bug.

Reading the nbdtab file in initramfs is not usually possible; after all, the nbdtab file is expected to be on the filesystem, not on the initramfs. Such initramfs environments are expected to deal with issuing the -m option themselves; it should not be necessary to specify that in configuration.

Of course, it's possible that you are trying to do something that I didn't think of, in which case I'm happy to be educated. In the absense of that, though, since specifying systemd-mark in nbdtab is highly unlikely to do what is expected, and since that that would cause confusion, I think the correct course of action here is to update the documentation and clarify that not all options make sense in an nbdtab file.

@yoe
Copy link
Member

yoe commented Oct 1, 2016

Fixed in the man page now.

@yoe yoe closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants