Remove commons lang as a compile time dependency #594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request remove the commons lang dependency such that it maybe excluded in maven or gradle.
There is very little usage of Commons Lang 3 in this library and most of the usage is builtin future JDK versions (e.g.
String.isBlank
is in JDK 11).I have left the dependency in Maven for projects that accidentally depend on this project to pull Commons Lang in as a transitive dependency.
We need this for our code base as we do not allow commons lang 3 in most of our projects.