Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YojimboClient state update logic #191

Merged
merged 1 commit into from Mar 20, 2023
Merged

Fix YojimboClient state update logic #191

merged 1 commit into from Mar 20, 2023

Conversation

kbirk
Copy link
Contributor

@kbirk kbirk commented Mar 20, 2023

When running some tests I noticed that the YojimboClient would sometimes sets its state to CLIENT_STATE_CONNECTED before the server would execute the OnServerClientConnected callback. Looking at the current logic the YojimboClient sets the state to CLIENT_STATE_CONNECTED when the netcode state is NETCODE_CLIENT_STATE_SENDING_CONNECTION_RESPONSE rather than when it is NETCODE_CLIENT_STATE_CONNECTED.

This PR fixes that.

@gafferongames
Copy link
Contributor

Thank you

@gafferongames gafferongames merged commit b2eda0a into mas-bandwidth:master Mar 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gafferongames gafferongames gafferongames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kbirk @gafferongames