Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests TestKernel2Vxlan2Memif and TestMemif2Vxlan2Kernel deleting NSC and NSE too long #81

Closed
denis-tingaikin opened this issue Mar 1, 2021 · 2 comments
Closed

Tests TestKernel2Vxlan2Memif and TestMemif2Vxlan2Kernel deleting NSC and NSE too long #81

denis-tingaikin opened this issue Mar 1, 2021 · 2 comments
Assignees
@denis-tingaikin
Labels
bug Something isn't working
Projects
Issue/PR tracking

Comments

@denis-tingaikin
Copy link
Member

Steps to reproduce

  1. Run basic suite from the integration tests.

Actual: TestKernel2Vxlan2Memif and TestMemif2Vxlan2Kernel delete NSC and NSE too long

Description

On deleting NAMESPACE we are doing this:

https://github.com/networkservicemesh/cmd-nsc-vpp/blob/master/main.go#L208-L211

It looks like RPC Close in these tests work incorrectly.
We should investigate the problem and fix it.
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Mar 1, 2021
@denis-tingaikin denis-tingaikin added this to Backlog in Issue/PR tracking via automation Mar 1, 2021
@denis-tingaikin denis-tingaikin self-assigned this Mar 1, 2021
@denis-tingaikin denis-tingaikin mentioned this issue Mar 1, 2021
Merged
@edwarnicke edwarnicke moved this from Backlog to To do in Issue/PR tracking Mar 1, 2021
@denis-tingaikin denis-tingaikin moved this from To do to In progress in Issue/PR tracking Mar 2, 2021
@denis-tingaikin denis-tingaikin mentioned this issue Mar 8, 2021
Closed
@denis-tingaikin
Copy link
Member Author

Fixed by #97

@denis-tingaikin
Copy link
Member Author

Before fix: tests have passed in 13m 34s https://github.com/networkservicemesh/integration-k8s-kind/runs/2059912086

After fix: tests have passed in 10m 47s https://github.com/networkservicemesh/integration-k8s-kind/pull/117/checks?check_run_id=2064811342

@haiodo haiodo closed this as completed Mar 9, 2021
Issue/PR tracking automation moved this from In progress to Done Mar 9, 2021
@denis-tingaikin denis-tingaikin changed the title Tests TestKernel2Vxlan2Memif and TestMemif2Vxlan2Kernel delete NSC and NSE too long Tests TestKernel2Vxlan2Memif and TestMemif2Vxlan2Kernel deleting NSC and NSE too long Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-tingaikin denis-tingaikin

Labels
bug Something isn't working
Projects
Issue/PR tracking
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove extra vppErrCh waiting denis-tingaikin/cmd-nsc-vpp
2 participants
@haiodo @denis-tingaikin