Move check for LogMax encoding error to parsing of report description #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one UPS [APC Back-UPS BX1600MI FW:294201G -302201G] is known to have encoding errors in its USB HID report description such that a conforming interpretation of the encoded LogicalMaximum value indicates that it is -1 and the resulting LogicalMin..LogicalMax range is 0..-1. The actual report values read are correctly encoded. Rather than log a range error each time a value is read we can detect the encoding error when the report description is read (once, at startup) and adjust for the encoding error at that time.
Fix whitespace in recent changes for LogMin/LogMax rectification
jimklimov
approved these changes
Dec 20, 2021
|
Thanks for pursuing this! |
|
Happy to be able to help. Thanks for merging this. Ping me if it shows up anything else in this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least one UPS [APC Back-UPS BX1600MI FW:294201G -302201G] is known
to have encoding errors in its USB HID report description such that a
conforming interpretation of the encoded LogicalMaximum value
indicates that it is -1 and the resulting LogicalMin..LogicalMax range
is 0..-1.
The actual report values read are correctly encoded. Rather than log
a range error each time a value is read we can detect the encoding
error when the report description is read (once, at startup) and
adjust for the encoding error at that time.
Closes #1208