Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2236 nut scanner reports non existent driver for nut discovery #2245

Conversation

aquette
Copy link
Member

@aquette aquette commented Dec 22, 2023

When discovering NUT, either with Avahi or old method, the reported driver is "nutclient", which doesn't (yet) exists.
This should be fixed to dummy-ups, which will use the repeater mode, while waiting for #2232

the short term fix is to symlink nutclient to dummy-ups (example on Debian):

cd /lib/nut && ln -s dummy-ups nutclient

Signed-off-by: Arnaud Quette <arnaud.quette@free.fr>
the previously pointed driver "nutclient" does not exist yet.
At least points to a sane working default

Signed-off-by: Arnaud Quette <arnaud.quette@free.fr>
Closes: #networkupstools/issues/2236

Signed-off-by: Arnaud Quette <arnaud.quette@free.fr>
@aquette aquette added this to In Progress in SmartNUT via automation Dec 22, 2023
@aquette
Copy link
Member Author

aquette commented Dec 22, 2023

seriously @jimklimov?
https://ci.networkupstools.org/job/nut/job/nut/job/PR-2245/1/pipeline-console/?selected-node=252

please put such targets as optional, and revise the CI to be dev friendly. Breaking the momentum for such errors is no good ;)

@jimklimov
Copy link
Member

Can't see details too well on mobile on the road, but errors look like broken automake syntax? Did you change the makefiles to match?

@aquette
Copy link
Member Author

aquette commented Dec 22, 2023

boils down to 1 single poor OpenIndiana failure among bagazillions working, and that destroys the whole castle :/

configure.ac:2739: error: possibly undefined macro: AC_DISABLE_STATIC

Please fix the CI @jimklimov, spasibo :)

@jimklimov
Copy link
Member

jimklimov commented Dec 22, 2023

Well, we sort of (officially) pride ourselves on supporting builds of NUT everywhere it could be built before, hence the very diverse CI-testing matrix with C99+ and 2000'ish or newer (du'jour and beyonder) toolkit implenentations. While not part of regular builds, there were in recent past questions about Solaris 8 and CentOS 6, and a few fixes to make those happen. Developer momentum can quite quickly happen on their few systems, but non-regression for everyone has to happen on all the 180-ish os/toolkit combos.

I'll try to check that code and error-report if there will be signal later in the night, or after holidays at worst. Maybe just some disk space ran out and diags were misread.

@aquette
Copy link
Member Author

aquette commented Dec 22, 2023

for sure a pride, I've been the one porting it for more than 15 years.
Still, that should block a final release, not a dev flow!
This CI thing of yours is so big, it's collapsing under its own weight!

I'm gonna force gates to move fast, we'll fix after ;)

@aquette aquette merged commit e70e8dd into networkupstools:master Dec 22, 2023
7 of 26 checks passed
SmartNUT automation moved this from In Progress to Done Dec 22, 2023
@aquette aquette deleted the 2236-nut-scanner-reports-non-existent-driver-for-nut-discovery branch December 22, 2023 19:56
@aquette aquette self-assigned this Dec 22, 2023
@jimklimov jimklimov added bug nut-scanner impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) labels Jan 2, 2024
@jimklimov jimklimov added this to the 2.8.2 milestone Jan 2, 2024
@jimklimov
Copy link
Member

As noted elsewhere, the issue was in the end due to NUT CI farm VM migration to a new provider, and it ended up pointing to a wrong container (not set up for builds) as the OI agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug impacts-release-2.8.1 Issues reported against NUT release 2.8.1 (maybe vanilla or with minor packaging tweaks) nut-scanner
Projects
SmartNUT
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants