-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian translation for NUT-Monitor #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. There's a few typos commented in the review, and a lot more cases where a generic "device" is translated as an "UPS" at expense of other device types that NUT can handle.
I understand there may be a point in providing a tool to end-user workstations to monitor specifically their UPSes and not care about other device types; I think it may be reasonable then to either deliver a separate similar locale file for those and maybe pick one or another by some packaging post-install magic, or to maintain this as a templated .po.in
file with substitution of strings for generic or specific translation of device during build (as chosen by some new configure
script option).
Another messy subject is translation of "favorite(s)" into different words and with varying plurality/singularity vs. original English strings. I did not use the GUI so can't say well which translation fits better per context where it is used; at worst these strings can be merged "as is" and translation can be enhanced later in other PRs if it does not sit well.
Then also there's the matter of hiding "NUT" from the app title and dropping the copyright, license and project/authorship strings which I think is a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trusting @jimklimov here since my Russian is still too poor
Thank you for your comments and suggestions. Made all the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for the update! A couple more typos found in the new commits...
scripts/python/app/locale/ru/ru.po
Outdated
|
||
#: NUT-Monitor:853 | ||
msgid "UPS load :" | ||
msgstr "Загрузка ИБП :" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут я споткнулся... не будет ли "нагрузка" (чем ИБП занят) правильнее? С другой стороны, у корабля или грузовика полная или нет "загрузка" (как доля от его ёмкости) и тут это может быть ближе по контексту.
Думаю, но не уверен, что ответ зависит от того, как оно выводится: в измеримых единицах вроде Амперов (полезная нагрузка) или в туманных процентах от максимума (загрузка).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Заглянул в учебник по электротехнике - по тексту везде используется термин "нагрузка". Исправил.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо за расследование :)
Add Russian translation for NUT-Monitor