Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node attr dict values container not customize-able #3202

Closed
chebee7i opened this issue Oct 22, 2018 · 0 comments
Closed

Node attr dict values container not customize-able #3202

chebee7i opened this issue Oct 22, 2018 · 0 comments

Comments

@chebee7i
Copy link
Member

For subclasses of the primary graph classes, it doesn't look like we allow the developer to specify a factory for the values of G.nodes. The code does:

self._node[node_for_adding] = attr

instead of calling a user-provided factory to create the object and then doing obj.update(attr). Similarly for the code in add_edge etc. This seems like an unintended omission given that we allow developers to specify a edge_attr_dict_factory.

Similarly, it doesn't look like we allow the developer to control self.graph.

@dschult dschult closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants