Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute migration script #137

Closed
ldusan84 opened this issue May 11, 2013 · 11 comments
Closed

Attribute migration script #137

ldusan84 opened this issue May 11, 2013 · 11 comments
Labels

Comments

@ldusan84
Copy link

@ldusan84 ldusan84 commented May 11, 2013

I would like to port attribute migration script from https://github.com/astorm/Pulsestorm/blob/master/magento-create-setup.php

Do you think it would be a useful addition?

@amenk
Copy link
Contributor

@amenk amenk commented May 11, 2013

Yes! Actually I thought I already suggested that to @AlanStorm, but I cant find my tweet...

Some thing I saw: The script does not export different labels per store. So it might be an idea to generate such calls: http://stackoverflow.com/a/16421888/288568

@ldusan84
Copy link
Author

@ldusan84 ldusan84 commented May 11, 2013

Great, I'll start working on it then and let you know when I am done.

I will also look into issue you mentioned.

@ldusan84
Copy link
Author

@ldusan84 ldusan84 commented May 14, 2013

I will be absent until Sunday, just wanted to let you know that I am working on this. When I finish everything I will submit my pull request. You can check my progress so far on:

https://github.com/ldusan84/n98-magerun/blob/attribute-migration-script/src/N98/Magento/Command/Developer/AttributeProductCommand.php

@cmuench
Copy link
Member

@cmuench cmuench commented May 15, 2013

@ldusan84 Thanks for implementing this. It's a very useful feature. If you are ready send me a pull request for the develop branch.

@ldusan84
Copy link
Author

@ldusan84 ldusan84 commented May 15, 2013

@amenk No problem, I'll let you know when I am done. I plan to include customer attributes support and write some tests.

Let me know if you have some ideas regarding code organization. Maybe this script should not be in "dev" group of commands and things like that.

@amenk
Copy link
Contributor

@amenk amenk commented May 29, 2013

I just added an option --update-script to config:get. Actually we should think about making an attribute-info command which displays the information easly readable and add the --update-script option for printing the migration script - what do you think?

But we can sure also refactor that later in case more attribute-info functionality is added.

@ldusan84
Copy link
Author

@ldusan84 ldusan84 commented May 29, 2013

I think that's a good idea, I can do it. Would you like me to create another branch for it?

@amenk
Copy link
Contributor

@amenk amenk commented May 29, 2013

it's basically up to you and depends how much rework is needed. I think it should be pretty simple so that could be done in the same branch and directly released as that command.

@astorm
Copy link
Contributor

@astorm astorm commented Jun 8, 2013

FYI: Doing a major GitHub re-organization. If you need to reference the original script, you can do so here https://github.com/astorm/MagentoAttributeMigrationGenerate

@cmuench
Copy link
Member

@cmuench cmuench commented Jun 9, 2013

@astorm Thanks for the hint.

@peterjaap
Copy link

@peterjaap peterjaap commented Sep 7, 2014

I think this ticket can be closed since we now have dev:setup:script:attribute.

@cmuench cmuench closed this Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.