[BUGFIX] Improve sys:cron:run input handling #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sys:cron:run is called without any arguments, a dialog is presented to the user where he can choose a job by entering a number. It was however also possible to execute a job by entering invalid input: - if 0 is entered, the last job in the list was executed - if a negative number was entered, the first job in the list was executed - if non-numeric value was entered, the last job in the list was executed This commit fixes the above issues by showing an error if incorrect input is supplied.
cmuench
added a commit
that referenced
this pull request
Jan 28, 2015
…handling [BUGFIX] Improve sys:cron:run input handling
|
Thanks |
steverobbins
pushed a commit
to steverobbins/n98-magerun
that referenced
this pull request
Apr 7, 2015
…input-handling [BUGFIX] Improve sys:cron:run input handling
steverobbins
pushed a commit
to steverobbins/n98-magerun
that referenced
this pull request
Apr 7, 2015
…input-handling [BUGFIX] Improve sys:cron:run input handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sys:cron:run is called without any arguments, a dialog is presented to the user where he can choose a job by entering a number.
It was however also possible to execute a job by entering invalid input:
This commit fixes the above issues by showing an error if incorrect input is supplied.