Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting command: dev:class:lookup #70

Closed
cmuench opened this issue Dec 28, 2014 · 5 comments
Closed

Porting command: dev:class:lookup #70

cmuench opened this issue Dec 28, 2014 · 5 comments

Comments

@cmuench
Copy link
Member

cmuench commented Dec 28, 2014

Resolves a grouped class name

@robbieaverill
Copy link
Contributor

With the introduction of plugins, perhaps class rewriting might become almost obselete?

@ktomk
Copy link
Collaborator

ktomk commented Dec 17, 2015

@robbieaverill Well, I might imagine what you want to say, but if so from that standpoint I would tend to add as well that class rewriting should have been used as much as last resort (and by default: not at all) as much as using interceptors in Magento 2 :).

I'm not yet profound with Magento 2 class rewrites so I can't say if it actually exists as it did in Magento 1. However Magento 2 does have class aliasing within the DI layer and that might come more close to what was the class rewrite in Magento 1. I'd say it's not that bad to have some commands related to that in the magerun2 toolchest. Perhaps dev:class:lookup is a well suited command name for such a functionality.

@robbieaverill
Copy link
Contributor

robbieaverill commented Dec 17, 2015

Hi Tom,

Good point. Preference is still relevant for this command especially with
controllers, and the odd rewrite that persists or is needed for a
particular reason.

R

@Vinai
Copy link

Vinai commented Dec 17, 2015

@cmuench
Copy link
Member Author

cmuench commented Aug 30, 2023

Implemented as dev:di:info command.

@cmuench cmuench closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants