Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

succeed/surround etc. wrappers should run in the template's context #38

Closed
janv opened this issue Sep 13, 2012 · 2 comments
Closed

succeed/surround etc. wrappers should run in the template's context #38

janv opened this issue Sep 13, 2012 · 2 comments

Comments

@janv
Copy link
Contributor

janv commented Sep 13, 2012

While using the wrappers, I was surprised that the properties of my context were not available at this, like everywhere else in the template. The this-context in the wrapper is window instead.

Was this an oversight or a conscious decision? If there are no reasons against it I would submit a pull request, but I'd like to hear if this is a good idea first.

(Additionally, setting a custom wrapper via Haml-Coffee-Assets' config.hamlcoffee.customSurround, did not seem to work, but that's a different issue)

@netzpirat
Copy link
Owner

Oops, this is definitely an oversight and a pull request is very welcome. When you change config.hamlcoffee.customSurround you need to clear the assets cache, so that the template will be recompiled with the new function reference.

@janv
Copy link
Contributor Author

janv commented Sep 13, 2012

I'll give it a try then.

I've also opened an issue in Haml-Coffee-Assets for the configuration problem at emilioforrer/haml_coffee_assets#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants