Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

succeed/surround etc. wrappers should run in the template's context #38

Closed
janv opened this Issue Sep 13, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

janv commented Sep 13, 2012

While using the wrappers, I was surprised that the properties of my context were not available at this, like everywhere else in the template. The this-context in the wrapper is window instead.

Was this an oversight or a conscious decision? If there are no reasons against it I would submit a pull request, but I'd like to hear if this is a good idea first.

(Additionally, setting a custom wrapper via Haml-Coffee-Assets' config.hamlcoffee.customSurround, did not seem to work, but that's a different issue)

Owner

netzpirat commented Sep 13, 2012

Oops, this is definitely an oversight and a pull request is very welcome. When you change config.hamlcoffee.customSurround you need to clear the assets cache, so that the template will be recompiled with the new function reference.

Contributor

janv commented Sep 13, 2012

I'll give it a try then.

I've also opened an issue in Haml-Coffee-Assets for the configuration problem at netzpirat/haml_coffee_assets#69

@netzpirat netzpirat closed this in d8836a8 Sep 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment