-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of my-cards page #45
Comments
So, was it a rendering issue or took a while to fetch from the contract? |
It must be about how we fetch the contract; rendering cannot take this long. I'm profiling it now. |
Please make different fixes in different commits and branches. |
Done in #47 |
Thanks! |
This issue is not fixed yet. I tried /my-cards again on the deployment of ac8f4f5. It took 9 seconds. Below is the performance display of Brave: There are 4 visible requests to the smart contract; and the render happens only after the last one. |
Is that mean fetching cards within a for loop from the contract takes too long when deployed to Göerli? I couldn't reproduce on deployed product since I have no minted cards and minting period has ended, unfortunately. |
Perhaps, needs to be investigated. One way to do would be logging timestamps on relevant requests and seeing them in action with local and Goerli deployments. |
Previous approach was;
This makes the contract calls last even longer. So, I've decided to update the card's state as a new card have constructed and render it immediately. I've created another branch and tested a new approach on Göerli. I think it does fine, but this approach is to render the cards immediately after we fetch them so, cards will be loaded one by one. If you agree with me on this approach, we can display a loading spinner until all the cards are fetched at the end of the list @hantuzun. |
When I've 11 cards, https://regen.bingo/my-cards takes a couple of seconds to load. It should load immidiately.
The text was updated successfully, but these errors were encountered: