Allow private constructors for the ContractlessStandardResolver, when using ctor attribute #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pianomanjh
force-pushed
the
bugfix/contractless-private-ctor
branch
from
d45b48c
to
11962c1
Compare
…d private constructors
pianomanjh
force-pushed
the
bugfix/contractless-private-ctor
branch
from
11962c1
to
db1f36e
Compare
|
Is there a procedure I need to follow for getting this reviewed? Do you prefer an issue to be filed first? Just let me know if there's anything I can do. |
|
This looks good to me. Thank you for submitting. I'm going to retarget this to our |
AArnott
approved these changes
Jun 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #530, but allows this feature for the ContractlessStandardResolver.
Private constructors explicitly marked with the
[SerializationConstructor]attribute should be honored, without requiring a private member option / resolver.Related #40