Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem while using #4

Closed
Ricardokevins opened this issue Nov 27, 2021 · 4 comments
Closed

A problem while using #4

Ricardokevins opened this issue Nov 27, 2021 · 4 comments

Comments

@Ricardokevins
Copy link

Ricardokevins commented Nov 27, 2021

Awesome Work~~

While using the implement in Repo, I have a question to comfirm:

BARTScore use generate loss as the score to estimate the quality of sentence.
In bart_score.score's implement, I notice the code under:

curr_score_list = [-x.item() for x in loss]

The returned ScoreList contains some negetive value.
if SummaryA get score -1 while SummaryB get Score -100
Does that means SummaryA is better than summaryB ? (becase the loss has been Negated?, loss1 is smaller than loss100)
appreciate any reply ~

@yyy-Apple
Copy link
Collaborator

Since we are using the average log-likelihood for target tokens, the values should be smaller than 0 (since the probability is between 0 and 1, so the log of it should be negative).

The higher the log-likelihood, the higher the probability, so the answer to your question is yes.

@Ricardokevins
Copy link
Author

Since we are using the average log-likelihood for target tokens, the values should be smaller than 0 (since the probability is between 0 and 1, so the log of it should be negative).

The higher the log-likelihood, the higher the probability, so the answer to your question is yes.

Thank a lot for your reply 👍 :)

@neubig
Copy link

neubig commented Nov 30, 2021

@yyy-Apple Could we add this to README.md somewhere? This is not immediately intuitive and I think it probably deserves an explanation.

@neubig neubig reopened this Nov 30, 2021
@yyy-Apple
Copy link
Collaborator

yyy-Apple commented Nov 30, 2021

@yyy-Apple Could we add this to README.md somewhere? This is not immediately intuitive and I think it probably deserves an explanation.

Have added Notes on use part in README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants