Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api improvements #120

Merged
merged 3 commits into from Jan 12, 2021
Merged

Api improvements #120

merged 3 commits into from Jan 12, 2021

Conversation

pgrill
Copy link
Collaborator

@pgrill pgrill commented Jan 4, 2021

Small fixes in the processor API

  • The response of the endpoints in the PUT and POST operation was changed to keep the GET format.
  • The metrics endpoints were refactored to avoid repeating code.

renzodgc
renzodgc approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@renzodgc renzodgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏

@pgrill pgrill merged commit fd054c9 into galliot-us:master Jan 12, 2021
@pgrill pgrill deleted the API-Improvements branch January 12, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzodgc renzodgc renzodgc approved these changes

@mats-claassen mats-claassen mats-claassen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgrill @mats-claassen @renzodgc