Enable slack notifications per entity #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrill
reviewed
Nov 20, 2020
api/models/config_keys.py
Outdated
| @@ -24,6 +24,7 @@ class NotificationConfig(SnakeModel): | |||
| violationThreshold: Optional[int] = Field(0, example=100) | |||
| notifyEveryMinutes: Optional[int] = Field(0, example=15) | |||
| emails: Optional[str] = Field("", example='john@email.com,doe@email.com') | |||
| enableSlackNotifications: Optional[str] = Field(False, example=False) | |||
There was a problem hiding this comment.
Maybe we can declare it as a bool field.
There was a problem hiding this comment.
I think it needs to be a string to be written in the config file
There was a problem hiding this comment.
🤔 But the daily report is declared as bool and it works.
If we declare it as a string, the field definition should be Field("False", example="False")
There was a problem hiding this comment.
You were right :), I got mixed up
mats-claassen
approved these changes
Nov 23, 2020
renzodgc
force-pushed
the
EnableSlackNotificationsPerEntity
branch
from
a3c0058
to
58572bc
Compare
pgrill
approved these changes
Nov 23, 2020
renzodgc
force-pushed
the
EnableSlackNotificationsPerEntity
branch
from
8d4cc5e
to
404fa79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Slack Configuration from a global config to each area/camera