Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues regarding ICD algorithm #71

Closed
3 tasks done
masoudabedinifar opened this issue Mar 26, 2024 · 3 comments
Closed
3 tasks done

Issues regarding ICD algorithm #71

masoudabedinifar opened this issue Mar 26, 2024 · 3 comments
Assignees

Comments

@masoudabedinifar
Copy link
Collaborator

masoudabedinifar commented Mar 26, 2024

Dear all,

The issues that need to be addressed regarding the ICD algorithm before submitting the JOSS paper could be listed as follows:

  1. Add dt_data as an optional input to the ICD algorithm as we did in GSD
  • We need to incorporate "dt_data" into the ICD algorithm to provide real-time information whenever it's available and given as an input to the algorithm. The onset should be updated accordingly.
  1. Error handling for the cases such as [KeepControl][https://github.com/Gait sequence detection 'GSD_Output' referenced before assignment #66]
  • Since the GSD algorithm requires at least 5 consecutive steps to detect the event as a gait sequence, the algorithm fails to identify the gait sequence for this special case. However, still we can apply ICD to the referred data. The issue should be solved in a way that 'gait_sequences' in https://github.com/neurogeriatricskiel/NGMT/blob/main/ngmt/modules/icd/_paraschiv.py should be optional.
    For this purpose, we need to change the algorithm in the following way. When 'gait_sequences' are not provided, the ICD should create artificial gait sequences that cover the active parts of the data and then identify initial contacts within defined limits.
  1. Vertical acceleration assignment [Vertical acceleration][https://github.com/Vertical acceleration #69]
  • We should try to avoid hard-coding of "acc_vertical = data["LowerBack_ACCEL_x"]" in the initial contact detection algorithm and use some methods to detect x component of the acceleration and then use it inside the algorithm to detect initial contacts.
@masoudabedinifar masoudabedinifar changed the title Issues reagrding ICD algorithm Issues regarding ICD algorithm Mar 26, 2024
@masoudabedinifar
Copy link
Collaborator Author

  1. dt_data was added as an optional input to the ICD algorithm with commit: 96caeeb

@rmndrs89
Copy link
Collaborator

rmndrs89 commented Apr 9, 2024

I have completed tasks 2 and 3. @JuliusWelzel could you transfer the "tracking_systems" and "tracked_points" algorithms for the GSD and ICD to the detect method as optional arguments??

@JuliusWelzel
Copy link
Contributor

Done in d3dcda1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants