Fix tests: flaky and not #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/ci.yaml
Outdated
| @@ -13,7 +13,7 @@ jobs: | |||
| name: Run tests | |||
| strategy: | |||
| matrix: | |||
| python-version: [3.6, 3.7] | |||
| python-version: [3.6], 3.7] | |||
There was a problem hiding this comment.
Is it means, that tests will be executed on 3.6 only?
There was a problem hiding this comment.
temp changes, to be reverted
tests/e2e/test_main.py
Outdated
| @@ -287,6 +295,7 @@ def test_image_build_env(cli_runner: CLIRunner) -> None: | |||
| assert result.returncode == 0, result | |||
|
|
|||
| secret = str(uuid.uuid4()) | |||
| print("secret", secret) | |||
There was a problem hiding this comment.
do we need it for debugging purposes?
mb let's hide it behind
try:
assert result.returncode == 0, result
except AssertionError as e:
click.echo(f"secret: {secret}")
raise
(the same for line 333)
Also, shouldn't the image name in line 165, 271 and 318 be also unique?
There was a problem hiding this comment.
mb let's hide it behind
no need to add logic for debug purposes only, tests should be as simple as possible
atemate
force-pushed
the
fix-tests-401-unauthorized
branch
from
fbdd369
to
9c4ef76
Compare
atemate
changed the title
neuro image tags test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
neuro image tagsfor images with >30 tags platform-registry-api#209. Needed to make CI green to make a release.assert f"git_token={secret}" in result.stdoutdidn't show up in stdout because this layer was cached and wasn't executed.Thanks @YevheniiSemendiak and @mariyadavydova for helping debug the problem!