Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coherence and temporarily remove PDC and DTC #113

Closed
richardkoehler opened this issue Oct 28, 2021 · 4 comments
Closed

Add Coherence and temporarily remove PDC and DTC #113

richardkoehler opened this issue Oct 28, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@richardkoehler
Copy link
Contributor

@timonmerk
We should maybe think about removing PDC and DTC from main again (and moving them to a branch) until we make sure that they are implemented correctly.
Instead we could think about adding simple coherence, which might be less specific but easier to implement and less computationally expensive.

@richardkoehler richardkoehler added the enhancement New feature or request label Oct 28, 2021
@timonmerk
Copy link
Contributor

Good point! @tsbinns Can you point out which function you use right now?
I would simply use scipy https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.coherence.html

@tsbinns
Copy link

tsbinns commented Nov 2, 2021

@timonmerk I'm using mne.connectivity.spectral_connectivity in the 'cwt_morlet' mode with 9 cwt cycles.

@richardkoehler
Copy link
Contributor Author

@timonmerk @tsbinns For real-time analysis, I think the scipy option would be the way to go right?

@tsbinns
Copy link

tsbinns commented Nov 2, 2021

@timonmerk @richardkoehler Computational cost isn't an immediate concern for me, so I haven't compared the two implementations in this regard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants