New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check in settings.py sampling frequency filter relation #38
Comments
@richardkoehler I am referencing from the PR to this issue here.
So at least the "3*self.line_noise" needs to be adapted wrt to the used sampling frequency. |
Something more tricky is probably the 'trans_bandwidth', since this heavily depends on the 'filter_length'. Higher 'filter_length' will allow for "sharper" filter functions. So it might be necessary to iteratively increase this parameter until the filter calculation is possible, or a more advanced way is possbile 😅 I think this issue comes up mainly with testing modules using openBCI though, since here fs is pretty low |
Notch filter params are set in relation to fs now |
For too low sampling frequencies, the current notch filter will fail.
Design filter in settings.py?
Settings.py should be written as class s.t. settings.json, df_M1 and
such code isn't part of start_BIDS / start_LSL anymore.
The text was updated successfully, but these errors were encountered: