Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored data augmentation, changed loss function, cleaned notebooks and other improvements #226

Merged
merged 117 commits into from Mar 13, 2020

Conversation

vasudev-sharma
Copy link
Contributor

@vasudev-sharma vasudev-sharma commented Jun 27, 2019

This major PR aims to handle the improvement in the performance of model as well as an improvised version of data augmentation.

DONE

Fixes #148, Fixes #19, Fixes #241, Fixes #278, Fixes #240 Fixes #273

vasudev-sharma and others added 30 commits June 3, 2019 17:36
* Notebook implementation of AxonDeepSeg(mini version)

* Notebook implementation of AxonDeepSeg(mini version)

* Incorpoation of Myelin and Axond dice coefficient and Cleaning of notebook
Updated Requirements.txt for Keras framework
@mathieuboudreau
Copy link
Member

@mathieuboudreau , shall we merge this PR, if it is reviewed ?

@vs74 I'll do one final pass tomorrow (Thursday), and retest the functionality hands on. If there's only minor issues, I'll open them as new separate issues so we can work on them individually.

ads_plugin.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@mathieuboudreau mathieuboudreau self-requested a review March 13, 2020 04:00
Copy link
Member

@mathieuboudreau mathieuboudreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vs74 Finished doing a final review. Did a lot of minor changes. Tested all the notebooks manually, and after some modifications they ran fine. The only thing I didn't thoroughly test is retraining an entire model (all epochs), however we trained the default models recently, so I don't suspect that any of the minor changes would impact it significantly (and the training is tested in the unit test for general errors anyways).

Everything looks good, ready to merge. This finalizes the new major release v3.0, which is reflected in the CHANGELOG.

Thanks so much for this major contribution @vs74 !

@mathieuboudreau mathieuboudreau merged commit 8905c59 into master Mar 13, 2020
@vasudev-sharma vasudev-sharma deleted the vs_data_aug_keras branch March 13, 2020 07:32
@vasudev-sharma vasudev-sharma mentioned this pull request Mar 17, 2020
@mariehbourget mariehbourget restored the vs_data_aug_keras branch May 13, 2020 17:21
@vasudev-sharma vasudev-sharma deleted the vs_data_aug_keras branch November 4, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants