Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better performance of deepseg seg_mice_gm-wm_dwi model if A-P orientation is wrong #3279

Closed
jcohenadad opened this issue Mar 14, 2021 · 5 comments · Fixed by #3321
Closed
Labels
enhancement category: improves performance/results of an existing feature sct_deepseg context: Global entry point for all deep learning segmentation methods user requested Raised by user on the SCT forum/email/GitHub. Be sure to notify them when fixed in a release.

Comments

@jcohenadad
Copy link
Member

jcohenadad commented Mar 14, 2021

Description

While working on a user's forum issue https://forum.spinalcordmri.org/t/registration-to-t1-ex-vivo-template-error/644/6, I noticed that sct_deepseg's model seg_mice_gm-wm_dwi performs better if the image is (wrongly) flipped in the A-P direction.

See below with the correct orientation, ie: we clearly see the dorsal horns pointing towards "A" whereas it should be "P":

wrong-orientation.mov

However, when fixing the wrong orientation of the image using the following function:

sct_image -i dwi_1500.nii.gz -setorient-data PSL -o dwi_1500_orient.nii.gz

Even though the image is now correctly oriented, the segmentation performance is largely decreased:

correct-orientation.mov

Which makes me wonder if the model may have been trained on flipped data? (ie: A-P were mislabeled). @charleygros

@jcohenadad jcohenadad added sct_deepseg context: Global entry point for all deep learning segmentation methods enhancement category: improves performance/results of an existing feature labels Mar 23, 2021
@charleygros
Copy link
Member

Which makes me wonder if the model may have been trained on flipped data? (ie: A-P were mislabeled). @charleygros

That's.... possible!!
What I'm gonna do: (1) flip the dataset, (2) retrain a model on this flip data, (3) compare the results, (4) make a call. Keep you posted.

@jcohenadad
Copy link
Member Author

i was about to suggest you wait for the data to be RPI (instead of LPI) but since the template is RL symmetric that shouldn’t change anything

@charleygros
Copy link
Member

i was about to suggest you wait for the data to be RPI (instead of LPI) but since the template is RL symmetric that shouldn’t change anything

Good point! But I think these data are not RL symmetric (while the template has been RL symmetrised).

@jcohenadad
Copy link
Member Author

i was about to suggest you wait for the data to be RPI (instead of LPI) but since the template is RL symmetric that shouldn’t change anything

Good point! But I think these data are not RL symmetric (while the template has been RL symmetrised).

ah! indeed. But data augmentation probably includes RL flip?

@charleygros
Copy link
Member

data augmentation probably includes RL flip?

Yess!!

@joshuacwnewton joshuacwnewton added this to Issues: To do in 5.3.0 Roadmap via automation Mar 30, 2021
@joshuacwnewton joshuacwnewton moved this from Issues: To do to Issues: Has linked PR in 5.3.0 Roadmap Mar 30, 2021
5.3.0 Roadmap automation moved this from Issues: In progress (has linked PR) to Issues/PRs: Done Apr 1, 2021
@joshuacwnewton joshuacwnewton added the user requested Raised by user on the SCT forum/email/GitHub. Be sure to notify them when fixed in a release. label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement category: improves performance/results of an existing feature sct_deepseg context: Global entry point for all deep learning segmentation methods user requested Raised by user on the SCT forum/email/GitHub. Be sure to notify them when fixed in a release.
Projects
No open projects
5.3.0 Roadmap
Issue/PR: Done
Development

Successfully merging a pull request may close this issue.

3 participants